Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove moveit2_humble.repos and moveit2_iron.repos files #3080

Merged
merged 7 commits into from
Nov 17, 2024

Conversation

sea-bass
Copy link
Contributor

Description

The only dependency that was in these files was an old version of generate_parameter_library which we do not need to be on at the moment.

I still kept the logic in the Dockerfiles in case there ever needs to be distro-specific repos files in future.

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

Copy link
Contributor

@sjahr sjahr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sjahr sjahr enabled auto-merge November 11, 2024 13:40
@sea-bass
Copy link
Contributor Author

sea-bass commented Nov 11, 2024

Hmm... is the new version of generate_parameter_library actually breaking things on Humble?
https://discourse.ros.org/t/new-packages-for-humble-hawksbill-2024-11-04/40422

https://github.com/moveit/moveit2/actions/runs/11779440054/job/32807896145?pr=3080#step:11:365


Weirdly enough I don't see in the logs generate_parameter_library being installed via binaries.

Is this something where we need to first merge a PR to humble to generate a new image?

@sea-bass
Copy link
Contributor Author

sea-bass commented Nov 11, 2024

I think the issue is that the humble-ci-testing job needs to succeed before new humble Docker images get released... but it's being blocked by a missing ros-humble-ros-base apt package not existing. Why? no idea.

https://github.com/moveit/moveit2/actions/runs/11781805227/job/32815416596#step:5:346


EDIT: Oh! Of course, the osrf/ros2:testing image is now on Ubuntu 24.04 -- see #3082

@pac48
Copy link
Contributor

pac48 commented Nov 11, 2024

@sea-bass Which version of generate_parameter_library is being installed by the CI / humble-ci job? I don't see it in the logs.

@sea-bass
Copy link
Contributor Author

@sea-bass Which version of generate_parameter_library is being installed by the CI / humble-ci job? I don't see it in the logs.

My going theory is that the docker image this is running on is stale because other jobs are failing. I am trying to see if landing #3082 first and then letting the humble moveit image build will fix things.

@sea-bass
Copy link
Contributor Author

@sea-bass Which version of generate_parameter_library is being installed by the CI / humble-ci job? I don't see it in the logs.

My going theory is that the docker image this is running on is stale because other jobs are failing. I am trying to see if landing #3082 first and then letting the humble moveit image build will fix things.

Confirming this:

$ docker run -it moveit/moveit2:humble-ci bash
root@4c149e72d515:~/ws_moveit# apt list --installed | grep generate-parameter

WARNING: apt does not have a stable CLI interface. Use with caution in scripts.

ros-humble-generate-parameter-library-py/now 0.3.8-1jammy.20240311.112120 amd64 [installed,local]
ros-humble-generate-parameter-library/now 0.3.8-1jammy.20240311.112627 amd64 [installed,local]

If I simply run an apt install --upgrade on those packages, I get 0.3.9-1 instead, which has the fixes we need.

Also, these logs from #3082 install the newer version:

https://github.com/moveit/moveit2/actions/runs/11782484963/job/32817611887?pr=3082#step:5:922

So I'm hopeful this will pass once #3082 is in

@sjahr sjahr enabled auto-merge November 15, 2024 09:52
@sea-bass
Copy link
Contributor Author

sea-bass commented Nov 15, 2024

This is not passing. Somehow the Humble CI job still is not installing the latest generate_parameter_library.

Is it that the ROS 2 Humble image is simply too old, and somehow the new package versions are not upgraded?

EDIT: Yep, #3104 should address this

@sea-bass
Copy link
Contributor Author

Humble Docker images are finally being pushed again! This is ready.

@sea-bass sea-bass merged commit 91b47a6 into main Nov 17, 2024
22 of 23 checks passed
@sea-bass sea-bass deleted the remove-humble-iron-repos-files branch November 17, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants